Skip to content

Fix widget editor block toolbar scrolling behavior #32177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
talldan wants to merge 1 commit into from
Closed

Fix widget editor block toolbar scrolling behavior #32177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions packages/edit-widgets/src/components/widget-areas-block-editor-content/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,22 @@ export default function WidgetAreasBlockEditorContent( {
blockEditorSettings,
} ) {
return (
<BlockTools>
<>
<KeyboardShortcuts />
<BlockEditorKeyboardShortcuts />
<Notices />
<div className="edit-widgets-block-editor editor-styles-wrapper">
<EditorStyles styles={ blockEditorSettings.styles } />
<BlockSelectionClearer>
<WritingFlow>
<ObserveTyping>
<BlockList className="edit-widgets-main-block-list" />
</ObserveTyping>
</WritingFlow>
</BlockSelectionClearer>
<BlockTools>
Copy link
Member

@ellatrix ellatrix May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BlockTools should be wrapped around the editor canvas (.editor-styles-wrapper). It should not be part of the canvas.

<Notices />
Copy link
Member

@ellatrix ellatrix May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, notices should not be part of the editor canvas.

<EditorStyles styles={ blockEditorSettings.styles } />
<BlockSelectionClearer>
<WritingFlow>
<ObserveTyping>
<BlockList className="edit-widgets-main-block-list" />
</ObserveTyping>
</WritingFlow>
</BlockSelectionClearer>
</BlockTools>
</div>
</BlockTools>
</>
);
}
1 change: 1 addition & 0 deletions packages/edit-widgets/src/components/widget-areas-block-editor-content/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
.edit-widgets-block-editor {
position: relative;
background: $gray-100;
padding: 0;
Copy link
Contributor Author

@talldan talldan May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensures the top toolbar and notices have no gap above them.


// This is the default font that is going to be used in the content of the areas (blocks).
font-family: $default-font;
Expand Down