Skip to content

Allow non-latin characters in slugs #32232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aristath merged 6 commits into from
Jun 2, 2021
Merged

Allow non-latin characters in slugs #32232

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc95217
fixes #24710
aristath May 26, 2021
4e4d38f
Additional test
aristath May 26, 2021
f545226
typo
aristath May 26, 2021
ae9f15f
fix failing tests
aristath May 26, 2021
a218cf8
update test description
aristath May 26, 2021
e55aed0
update docs
aristath May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test description
  • Loading branch information
@aristath
aristath committed Jun 2, 2021
commit a218cf8d5c59d30daea4942c1130a866ec630b4e
2 changes: 1 addition & 1 deletion packages/editor/src/utils/test/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ describe( 'cleanForSlug()', () => {
expect( cleanForSlug( '/Is th@t Déjà_vu? ' ) ).toBe( 'is-tht-deja_vu' );
} );

it( 'Should allow unicode characters', () => {
it( 'Should allow non-latin characters', () => {
expect( cleanForSlug( 'Καλημέρα Κόσμε' ) ).toBe( 'καλημέρα-κόσμε' );
} );

Expand Down