Skip to content

Block editor: use React events for shortcuts (portal bubbles & contextual) #32323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 6 commits into from
Jul 22, 2021
Merged

Block editor: use React events for shortcuts (portal bubbles & contextual) #32323

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d4294d1
Block editor: use React events for shortcuts (portal bubbles & contex…
ellatrix May 28, 2021
120f227
Reduce divs
ellatrix May 28, 2021
bd596fc
Fix rebase error
ellatrix Jul 16, 2021
9f0d7a0
Fix access shortcut
ellatrix Jul 18, 2021
2d6754a
Fix unit tests
ellatrix Jul 22, 2021
bce98da
Fix e2e test
ellatrix Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix access shortcut
  • Loading branch information
@ellatrix
ellatrix committed Jul 22, 2021
commit 9f0d7a0aeb249851d3265967f797a005aad858ad
6 changes: 5 additions & 1 deletion packages/keycodes/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,11 @@ export const isKeyboardEvent = mapValues( modifiers, ( getModifiers ) => {
return false;
}

const key = event.key.toLowerCase();
let key = event.key.toLowerCase();

if ( includes( mods, ALT ) ) {
key = String.fromCharCode( event.keyCode ).toLowerCase();
}

if ( ! character ) {
return includes( mods, key );
Expand Down