Skip to content

Conversation

@aduth
Copy link
Member

@aduth aduth commented Mar 24, 2017

Expands upon #321...

  • Further simplify entry configuration
  • Bump hpq dependency to v1.1.1 which resolves issue noted at Explicitly target entry modules #321 (comment) and avoids need to specifically target dependencies to be included in Babel transpilation

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtias mtias added the Framework Issues related to broader framework topics, especially as it relates to javascript label Mar 24, 2017
@aduth aduth force-pushed the update/webpack-entry-module branch from 9a8b554 to fa8cd1c Compare March 24, 2017 14:39
@aduth
Copy link
Member Author

aduth commented Mar 24, 2017

fa8cd1c flattens folder structure, effectively removing modules (moving its contents to top-level directory).

Ensures errors in e.g. webpack.config.js are flagged
@youknowriad
Copy link
Contributor

👍 for dropping the top level modules directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Framework Issues related to broader framework topics, especially as it relates to javascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants