-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Handbook: Detail the Gutenberg release post process #32429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gziolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Thank you for adding more details to how the process works in practice 👍🏻
I think @youknowriad is the best person to perform another review.
ntsekouras
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always great to see such enhancements! Thanks @priethor 💯
|
|
||
| #### 4. Running the performance tests | ||
|
|
||
| Your post should also include a performance audit at the end, comparing the current Gutenberg release with both the previous one and the latest WordPress major version. You can use `bin/plugin/cli.js perf` to automatically do this for you by passing as parameters the tags to run the performance suite against, such as `bin/plugin/cli.js perf release/x.y release/x.z wp/a.b` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now we have a job that is run on CI that gives you the results, so there's no need to run this on your own in theory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I see there is such a job, although it failed for the 10.7.0 to 10.7.4 releases when running the perf tests on the 5.7 branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @mcsf updated the job to use the latest WP release as base branch which should in theory make it more stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I failed to add that it should be fixed in 10.8 thanks to #32244 👍
youknowriad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here
Description
Updates the Gutenberg release process handbook page to expand the "Writing the Release Notes and Post" based on the last release iterations.