Skip to content

Conversation

@priethor
Copy link
Contributor

@priethor priethor commented Jun 3, 2021

Description

Updates the Gutenberg release process handbook page to expand the "Writing the Release Notes and Post" based on the last release iterations.

@priethor priethor added the [Type] Developer Documentation Documentation for developers label Jun 3, 2021
@priethor priethor requested review from gziolo and ockham June 3, 2021 12:41
@gziolo gziolo requested a review from youknowriad June 7, 2021 09:25
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thank you for adding more details to how the process works in practice 👍🏻

I think @youknowriad is the best person to perform another review.

@gziolo gziolo requested a review from a team June 7, 2021 09:28
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always great to see such enhancements! Thanks @priethor 💯


#### 4. Running the performance tests

Your post should also include a performance audit at the end, comparing the current Gutenberg release with both the previous one and the latest WordPress major version. You can use `bin/plugin/cli.js perf` to automatically do this for you by passing as parameters the tags to run the performance suite against, such as `bin/plugin/cli.js perf release/x.y release/x.z wp/a.b`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now we have a job that is run on CI that gives you the results, so there's no need to run this on your own in theory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I see there is such a job, although it failed for the 10.7.0 to 10.7.4 releases when running the perf tests on the 5.7 branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @mcsf updated the job to use the latest WP release as base branch which should in theory make it more stable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I failed to add that it should be fixed in 10.8 thanks to #32244 👍

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here

@draganescu draganescu merged commit eff93de into trunk Jun 7, 2021
@draganescu draganescu deleted the docs/update-gutenberg-release-post-process branch June 7, 2021 10:30
@github-actions github-actions bot added this to the Gutenberg 10.9 milestone Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants