Skip to content

Add Unlink button to LinkControl popover #32541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 7 commits into from
Jun 30, 2021
Merged

Add Unlink button to LinkControl popover #32541

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d3c2e3
Adds initial Unlink button
getdave Jun 9, 2021
cd64845
Add dedicated opt in prop for removing links
getdave Jun 29, 2021
478c2ae
Add tests
getdave Jun 29, 2021
550b4f0
Update docs
getdave Jun 29, 2021
441744e
Focus PR by removing unneeded onChange handler change
getdave Jun 29, 2021
fde237c
Use more accessible query for button
getdave Jun 29, 2021
545ace8
Remove checking if onRemove is a function.
getdave Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docs
  • Loading branch information
@getdave
getdave committed Jun 29, 2021
commit 550b4f01bfd41a6118e908d71f061b06213de596
8 changes: 8 additions & 0 deletions packages/block-editor/src/components/link-control/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,14 @@ This `suggestion` will then be _automatically_ passed to the `onChange` handler

As a result of the above, this prop is often used to allow on the fly creation of new entities (eg: `Posts`, `Pages`) based on the text the user has entered into the link search UI. As an example, the Navigation Block uses `createSuggestion` to create Pages on the fly from within the Block itself.

### onRemove

- Type: `Function`
- Required: No
- Default: null

An optional handler, which when passed will trigger the display of an `Unlink` UI within the control. This handler is expected to remove the current `value` of the control thus resetting it back to a default state. The key use case for this is allowing users to remove a link from the control without relying on there being an "unlink" control in the block toolbar.

#### Search `suggestion` values

A `suggestion` should have the following shape:
Expand Down