Remove snapshots from tests for LinkControl #32592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] Link Editing
|
Size Change: 0 B Total Size: 1.03 MB ℹ️ View Unchanged
|
kevin940726
approved these changes
Jun 11, 2021
Member
kevin940726
left a comment
kevin940726
left a comment
There was a problem hiding this comment.
Thanks! The follow-up makes sense too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #31464 @youknowriad said:
I completely agree. I'm not generally a fan of snapshots and find them to all little value to the majority of tests. To this end I've removed the snapshots from the tests for LinkControl.
Note how having removed said snapshots the utility of the tests has not diminished. This is because the underlying tests were already written in a manner such that they made assertions directly.
That being said, in a follow up I'm going to utilise React Testing Library to convert some assertions over to text matches to avoid relying on
classNameswhich - after all - are not a user-perceiveable API.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).