Skip to content

Conversation

@jorgefilipecosta
Copy link
Member

This PR fixes a logic mistake. When backporting to the core in WordPress/wordpress-develop#1368 I noticed that without this fix themes were not able to set an empty palette via add theme supports.

@jorgefilipecosta jorgefilipecosta added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Jun 14, 2021
@oandregal oandregal added the [Type] Bug An existing feature does not function as intended label Jun 15, 2021
@oandregal oandregal changed the title Fix: Logic on theme.json constructor. Allow presets to provide an empty set of values Jun 15, 2021
@youknowriad youknowriad added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 15, 2021
@oandregal oandregal merged commit fd32ab1 into trunk Jun 15, 2021
@oandregal oandregal deleted the fix/logic-on-theme-json-contructor branch June 15, 2021 08:37
@oandregal
Copy link
Member

This has been already ported to core as part of WordPress/wordpress-develop#1368

@youknowriad youknowriad removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 15, 2021
@talldan talldan added this to the Gutenberg 10.9 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants