Template creation: Fixed a problem that when a new template is created, the template is not displayed in the select box. #32735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
added
the
[Feature] Template Editing Mode
|
Size Change: +154 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jun 16, 2021
| yield controls.dispatch( editorStore, 'updateEditorSettings', { | ||
| ...settings, | ||
| availableTemplates: newAvailableTemplates, | ||
| } ); |
Contributor
There was a problem hiding this comment.
Thanks for fixing this :)
While this works, it feels a bit like a hack to me because it address only one use-case: the template being created from the template sidebar. Other plugins could have their own UIs and rely on actions directly.
I think the ideal solution for me would be to drop the availableTemplates entirely and use a getEntityRecords selector call to fill the the template selector instead.
Do you think it's possible to explore this alternative and compare solutions?
Member
Author
There was a problem hiding this comment.
@youknowriad Thanks! I've modified it to use getEntityRecords.
Contributor
There was a problem hiding this comment.
I actually think you misunderstand my suggestion 😬. I was proposing to keep this PR as is and open another when we don't update the action but instead update the template selector UI to not rely on getSettings().availableTemplates but to use getEntityRecords call directly (or an alternative REST API endpoint).
Member
Author
There was a problem hiding this comment.
7 tasks
Contributor
|
Closing this as fixed in #32744 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating a new template and returning to the editor, the new template is not displayed in the select box. It shows up when the browser is reloaded. Fixed this problem.
2021-06-16.21.04.09.mov
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).