Avoid generic function names for page list block internal functions #32736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
ntsekouras
approved these changes
Jun 16, 2021
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
I don't have any alternative proposal for the names, but these are pretty self explanatory about their scope.
Thanks Riad!
mcsf
approved these changes
Jun 16, 2021
Contributor
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
This is exactly what I had in my workdir. :)
youknowriad
removed
the
Backport to WP 6.9 Beta/RC
youknowriad
added a commit
that referenced
this pull request
Jun 21, 2021
youknowriad
added a commit
that referenced
this pull request
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #28265 (comment)
I'm not sure these are the best names but I tried renaming these functions so they don't look as generic WP APIs and more internal functions used by the block's server side code.