-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Alternate Safari 13 fix. #32773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Alternate Safari 13 fix. #32773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Okay, this isn't ready for review, but in order to test in Browserstack apparently it can't be a "draft" PR. |
Contributor
Author
|
Closing in favor of #32775 🙈 — apologies for the pings. |
|
Size Change: -5 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #32767 for the bulk.
The difference in this one is that it removes both height and min-height values, and in one session testing TT1 fixed both the issue of very little content and very much content for me.
It's a curious issue, and worth testing in at least a few themes with both lots and littl content.
Checklist:
*.native.jsfiles for terms that need renaming or removal).