Fix drag and drop indices when block list contains a style element #32776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: -1 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
mcsf
approved these changes
Jun 23, 2021
Contributor
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
This makes sense, but it would be nice to have a test to go along with it.
talldan
force-pushed
the
fix/drag-and-drop-indicies
branch
from
b2de5fd to
c31a9ba
Compare
Contributor
Author
|
Thanks @mcsf. I'll have a look into an e2e test as a follow-up. |
youknowriad
removed
the
Backport to WP 6.9 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 25, 2021
…32776) * Check for style elements * Use wp-block classname * Remove test that is no longer valid
youknowriad
pushed a commit
that referenced
this pull request
Jun 25, 2021
…32776) * Check for style elements * Use wp-block classname * Remove test that is no longer valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently
<style>elements started appearing block lists. This caused an issue with drag and drop, which expected only block elements in block lists. When these style elements appeared, they would result in the drop index being offset incorrectly.This fixes by filtering style elements out of the list of elements to be considered to be blocks.
How has this been tested?
trunkthe wrong drop target shows, but in this branch the correct one shows.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).