Fix for calling collapsed of null #3280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
approved these changes
Nov 1, 2017
| // Generate the wrapper class names handling the different states of the block. | ||
| const { isHovered, isSelected, isMultiSelected, isFirstMultiSelected, focus } = this.props; | ||
| const showUI = isSelected && ( ! this.props.isTyping || focus.collapsed === false ); | ||
| const showUI = isSelected && ( ! this.props.isTyping || ( focus && focus.collapsed === false ) ); |
Member
There was a problem hiding this comment.
Minor / unrelated: Do we need to check that this is explicitly false, or could we simplify to ! focus.collapsed ?
3 tasks
mcsf
force-pushed
the
fix/collapsed-null-bug
branch
from
7090252 to
50660df
Compare
Contributor
|
Rebased after merging #3297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Guards against null values before calling properies
Fix for #3275
How Has This Been Tested?
Manually
Screenshots (jpeg or gifs if applicable):
Types of changes
Checklist: