Remove @wordpress/editor as a dependency from @wordpress/block-library #32801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
|
Size Change: +16 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
…y when GUTENBERG_PHASE is 1
noisysocks
force-pushed
the
fix/remove-editor-dep-from-block-library
branch
from
18d6b31 to
1ce466a
Compare
Member
|
It's very similar to how gutenberg/packages/server-side-render/src/index.js Lines 19 to 20 in f4f3844 It's a bit unfortunate that we need to work around it like this but we haven't found a better solution so far. We might need to explore using the block context to pass down the necessary data, similar to how it's handled with the Post Template block: gutenberg/packages/block-library/src/post-template/block.json Lines 9 to 12 in f4f3844 gutenberg/packages/block-library/src/post-template/edit.js Lines 27 to 45 in f4f3844 |
gziolo
approved these changes
Jun 18, 2021
gziolo
added
the
Backport to WP 6.9 Beta/RC
youknowriad
removed
the
Backport to WP 6.9 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
…y when GUTENBERG_PHASE is 1 (#32801)
Contributor
|
@gziolo @noisysocks I think this PR (or something related) is triggering an eslint error o n #32848 because of the missing dependency. How come the tests is not failing on trunk? |
Member
|
@youknowriad, it's very strange that it didn't come up as an issue on Line 66 in ee69822 |
7 tasks
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
…y when GUTENBERG_PHASE is 1 (#32801)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@wordpress/block-libraryshould not depend on@wordpress/editoras blocks can be loaded into more contexts than the post or page editor. It also breaks the widgets screen, see Core-53437.How has this been tested?
package.jsonand setGUTENBERG_PHASEto1.npm run buildcat build/block-library/index.asset.phpwp-editorshould not appear in the array of dependencies that is output.Checklist:
*.native.jsfiles for terms that need renaming or removal).