[RNMobile] Tweaks to Badge Component's Styling #32865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The background colour of the badge component is updated to a darker gray colour with this commit (from $gray-70 to $gray-dark). This matches the colour of the edit button, which is displayed to the upper right of the image block when selected.
SiobhyB
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
The component's margin and padding is updated with this commit to match the original designs for the badge component.
2 tasks
Contributor
Author
|
@iamthomasbishop, I've made an initial pass at correcting the component's styles based on your feedback. I've followed the original padding/margin for the badge component, but let me know if there's anything else you think needs changing here. I prefer the larger margin when the badge is by itself (without the edit button displaying) but wondered whether the badge may now look a bit "off" when displayed alongside the image block's edit button. It's possible I've been staring at this too long. :D I'll defer to your preference here, as I don't have a super strong opinion either way.
|
iamthomasbishop
approved these changes
Jun 22, 2021
iamthomasbishop
left a comment
iamthomasbishop
left a comment
There was a problem hiding this comment.
Thanks for the ping, @SiobhyB ! This looks pretty good, esp the last example above, because it's closer to vertically centered with the edit button on the opposite side:
Let's roll with that for now, and we can always iterate if necessary in the future. Nice work!
It was agreed that the original margin of 8px works better for the badge, as it is more vertically aligned with the image block's edit badge. See: #32865 (review)
Contributor
Author
|
Thank you for this @iamthomasbishop, I've gone ahead to update the margin to the |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#3642Description
This PR includes some tweaks to the badge component's styling. Specifically, it reduces its padding and changes the background color to a darker gray.
How has this been tested?
The updated badge component was compared to the original design mocks here:
To view the badge component:
Screenshots
Tested on a Pixel 3a emulator, Android 10
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).