Skip to content

Navigation Overlay: Improve handling of open overlay. #32886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasmussen merged 2 commits into from
Jul 2, 2021
Merged

Navigation Overlay: Improve handling of open overlay. #32886

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31fd743
Navigation Overlay: Improve handling of open overlay.
jasmussen Jun 22, 2021
18def00
Fix for iframe.
jasmussen Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix for iframe.
  • Loading branch information
@jasmussen
jasmussen committed Jul 1, 2021
commit 18def004fd511e7fd1311c48e9d79ee81db7b391
7 changes: 7 additions & 0 deletions packages/block-library/src/navigation/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,13 @@ $color-control-label-height: 20px;
}
}

// The iframe makes these rules a lot simpler.
body.editor-styles-wrapper .wp-block-navigation__responsive-container.is-menu-open {
top: 0;
right: 0;
bottom: 0;
left: 0;
}

// Without this, the block cannot be selected, nor does the right container get focus.
// @todo: this is disruptive. Ideally we can retire a few of the containers,
Expand Down