Fix collapsing appender when paragraph disabled. #32894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
Contributor
Author
|
@youknowriad this could be a candidate for backporting. |
|
Size Change: +16 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
chrisvanpatten
approved these changes
Jun 22, 2021
Contributor
chrisvanpatten
left a comment
chrisvanpatten
left a comment
There was a problem hiding this comment.
Admittedly I had some build issues (on my side, unrelated to this PR) and was only able to test this by applying the style in-browser, but this definitely resolved the issue for me! Thanks for the quick patch @jasmussen!
jasmussen
force-pushed
the
fix/disabled-paragraph-appender
branch
from
fad593e to
0ba250e
Compare
youknowriad
added
Backport to WP 6.9 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #32891, with context in #28219 (comment).
If you have the Paragraph block disabled, whether manually or through a custom post type, the plus button collapses to this:
The SVG has zero width:
This PR sets flex-shrink to zero, causing it to not collapse:
It would be nice to revisit this particular appender and offer a bigger one, such as what's seen in the group block. We might even revisit that appender component entirely and provide an ability to select it, like so:
But that's a bigger undertaking, and this being a very small change can serve as a hotfix.
How has this been tested?
Add a custom post type that disables the paragraph, or just disable the paragraph in your preferences:
Create a new empty post, and you should see a black plus button.
Checklist:
*.native.jsfiles for terms that need renaming or removal).