Skip to content

Fix a regression where custom-units are forced as an array. #32898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
desrosj merged 2 commits into from
Jun 23, 2021
Merged

Fix a regression where custom-units are forced as an array. #32898

desrosj merged 2 commits into from
Jun 23, 2021

Conversation

@desrosj
Copy link
Member

@desrosj desrosj commented Jun 22, 2021

Description

This copies over the updates made in the WP Core SVN repo to address Trac-53472.

See Core-51203.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@youknowriad youknowriad self-assigned this Jun 22, 2021
@youknowriad youknowriad added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 22, 2021
@desrosj desrosj merged commit f1aacbb into trunk Jun 23, 2021
@desrosj desrosj deleted the trac/53472 branch June 23, 2021 02:21
@github-actions github-actions bot added this to the Gutenberg 11.0 milestone Jun 23, 2021
@youknowriad youknowriad removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 24, 2021
youknowriad pushed a commit that referenced this pull request Jun 24, 2021
@desrosj @youknowriad
Fix a regression where custom-units are forced as an array. (#32898)
93f6563 
* Fix a regression where `custom-units` are forced as an array.
youknowriad pushed a commit that referenced this pull request Jun 24, 2021
@desrosj @youknowriad
Fix a regression where custom-units are forced as an array. (#32898)
5581b71 
* Fix a regression where `custom-units` are forced as an array.
@oandregal oandregal mentioned this pull request Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowriad youknowriad youknowriad approved these changes

@oandregal oandregal Awaiting requested review from oandregal

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@youknowriad youknowriad

Labels

None yet

Projects

None yet

Milestone

Gutenberg 11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@desrosj @youknowriad