Skip to content

Conversation

@youknowriad
Copy link
Contributor

This tiny PR sets to the wholte gutenberg page's background to white.

Before
screen shot 2017-03-27 at 10 19 11

After
screen shot 2017-03-27 at 10 19 42

Maybe we should update the notifications CSS for this page too.

@youknowriad youknowriad added Design Framework Issues related to broader framework topics, especially as it relates to javascript labels Mar 27, 2017
@youknowriad youknowriad self-assigned this Mar 27, 2017
@youknowriad youknowriad requested a review from jasmussen March 27, 2017 09:25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to consider a better way to scope this if the styles are to be integrated amongst others in a core admin stylesheet, but this may be fine for now.

Perhaps body.toplevel_page_gutenberg ? Or otherwise creating an editor canvas element that's positioned absolute or fixed to the corners of the screen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm Right! I was assuming this CSS would be loaded only on this page. update to use the body.toplevel_page_gutenberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Framework Issues related to broader framework topics, especially as it relates to javascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants