Add a SearchControl component and reuse accross the UI #32935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] UI Components
youknowriad
requested review from
ajitbohra,
chrisvanpatten and
ellatrix
as code owners
7 tasks
|
Size Change: -212 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jun 23, 2021
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Looks great to me:
There's a small bottom border present in the template part search picker which doesn't seem necessary anymore, this one:
We can probably remove that.
Contributor
sarayourfriend
left a comment
sarayourfriend
left a comment
There was a problem hiding this comment.
I think converting this to use BaseControl is a good idea.
Not sure about wordpress/i18n it may be an inextricable dependency of components 🤷
What do you think about adding some tests for this component?
youknowriad
force-pushed
the
add/search-control
branch
from
04c946a to
759bc9c
Compare
Contributor
Author
|
Add the BaseControl usage to the component, which means now, it supports help and hideLabelFromVision (which I made true by default for this control, it seemed like a better default for a Search control) |
Contributor
Author
|
I could use some help here with the react native failures @mchowning @geriux |
Member
Sure! I'll check it out 👍 |
Member
|
@youknowriad 👋 it is currently failing because of the missing Adding that file with the styles fixes the issue. |
Contributor
Author
|
@geriux Thanks for the hint, I think I fixed it (moved the styles from the inserter native style to the search control one), let's see what the tests say. |
youknowriad
force-pushed
the
add/search-control
branch
from
5bffc52 to
11c7322
Compare
youknowriad
force-pushed
the
add/search-control
branch
from
e1a97b5 to
fc6accc
Compare
youknowriad
force-pushed
the
add/search-control
branch
from
69f49cc to
5bc8bb7
Compare
9 tasks
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #32922
The need for a reusable search control UI component became clear over time. It's now being used in three places: Inserter, Block Manager and Template Part placeholder state.
I tried to make its API close to all the other
*Controlcomponents. I think we can still push it further by reusingBaseControland providinghelp,hideLabelFromVisionprops support and things like that.Testing instructions