Set display only when form not hidden #33015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Feature] Widgets Screen
noisysocks
added
the
Backport to WP 6.9 Beta/RC
|
Size Change: +28 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
6 tasks
kevin940726
approved these changes
Jun 28, 2021
Member
kevin940726
left a comment
kevin940726
left a comment
There was a problem hiding this comment.
LGTM 👍
Just want to add some references here. From mdn.
Changing the value of the CSS
displayproperty on an element with thehiddenattribute overrides the behavior. For instance, elements styleddisplay: flexwill be displayed despite thehiddenattribute's presence.
7 tasks
youknowriad
removed
the
Backport to WP 6.9 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 28, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33000; alternative to #33006 based on @stokesman 's feedback.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).