Fix switcher focus style. #33031
Merged
Fix switcher focus style. #33031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: -33 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
Contributor
Author
|
I pushed an additional fix that polishes the Reusable Blocks dropdown spacing. Before:
After:
This has also been tested with when there's only a single block:
And with template parts:
|
Contributor
Author
|
Note that the glitchy focus style in all these GIFs is fixed by #33022. Must be a recent rendering engine change. |
mtias
reviewed
Jun 28, 2021
| // Ensure the icon buttons remain square. | ||
| &.has-icon { | ||
| // This needs specificity. | ||
| &.has-icon.has-icon { |
Contributor
Author
There was a problem hiding this comment.
Short answer: it incrementally increases the specificity of this rule.
Longer answer, it adds specificity to override this inherited padding:
This wasn't necessary in the past, since the icon was centered inside the 48x48 button. But once you add text, such as in reusable blocks, that lower padding will be leveraged. By setting higher specificity and bigger padding, we get it right:
Much longer answer: the block toolbar works decently as is. But having grown organically from features across the years, the CSS is at a level of complexity where it'd be nice to revisit it in a refactor.
mtias
approved these changes
Jun 28, 2021
Contributor
Author
|
Thanks for the review! |
7 tasks
This was referenced Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The focus style of the switcher is off:
This PR fixes it:
As I look at the code here, the refactor from the old block toolbar style to the new plus recent feature additions have built up the complexity a fair bit. Now that we don't have to support IE11 anymore, I think there's an opportunity to refactor this whole component to be vastly simpler. We'd need to remove some fragments and revisit a few extensibility points and CSS classes, so I'd love someone to pair up with on this — of you're interested, let me know.
How has this been tested?
Insert a block, focus the switcher. The focus style should be square.
Checklist:
*.native.jsfiles for terms that need renaming or removal).