Skip to content

Conversation

@manooweb
Copy link
Contributor

@manooweb manooweb commented Jun 28, 2021

Fixes #32750

Simply replace the svg <path> tag with the new one exported from Figma
https://www.figma.com/file/e4tLacmlPuZV47l7901FEs/WordPress-Design-Library?node-id=5415%3A22557

@Mamaduka Mamaduka added [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Package] Icons /packages/icons labels Jun 30, 2021
@critterverse
Copy link
Contributor

This looks so much better, thanks @manooweb! The only thing I noticed when testing is that the alignment for this icon is a bit off-center. It looks to be 3px up and 4px left of center (in the block toolbar, block inspector, inserter panel, etc). Here's what I'm seeing with a red icon overlayed to show where the icon appears for other blocks:

legacy-widget-icon

@manooweb
Copy link
Contributor Author

manooweb commented Jul 5, 2021

This looks so much better, thanks @manooweb! The only thing I noticed when testing is that the alignment for this icon is a bit off-center. It looks to be 3px up and 4px left of center (in the block toolbar, block inspector, inserter panel, etc). Here's what I'm seeing with a red icon overlayed to show where the icon appears for other blocks:

legacy-widget-icon

Yes! You're right. 🤔 It's strange that styles seem not correctly applied for this icon. I'm going to look for that 😉

@manooweb
Copy link
Contributor Author

manooweb commented Jul 5, 2021

Sorry I didn't correctly exported the legacy widget icon from Figma. Its margins were missing.
I pushed again and now it should be good.

@critterverse
Copy link
Contributor

This looks great 👍
Let me know if you need any help requesting a code review @manooweb!

@manooweb
Copy link
Contributor Author

manooweb commented Jul 6, 2021

This looks great 👍
Let me know if you need any help requesting a code review @manooweb!

@critterverse Yes! I have no access on this repository to request one.

@adamziel adamziel added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 6, 2021
@adamziel adamziel merged commit cc6a6b6 into WordPress:trunk Jul 6, 2021
@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 6, 2021
youknowriad pushed a commit that referenced this pull request Jul 6, 2021
* Replace legacy widget icon with its new version

* Fix the legacy widget with its correct version from Figma
@youknowriad youknowriad removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 6, 2021
youknowriad pushed a commit that referenced this pull request Jul 6, 2021
* Replace legacy widget icon with its new version

* Fix the legacy widget with its correct version from Figma
@manooweb manooweb deleted the swap-legacy-widget-icon branch July 6, 2021 13:05
youknowriad pushed a commit that referenced this pull request Jul 7, 2021
* Replace legacy widget icon with its new version

* Fix the legacy widget with its correct version from Figma
sarayourfriend pushed a commit that referenced this pull request Jul 15, 2021
* Replace legacy widget icon with its new version

* Fix the legacy widget with its correct version from Figma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Package] Icons /packages/icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swap the Legacy Widget block icon (with version that matches icon template more closely)

5 participants