Skip to content

Try: Polish labels and consolidate options in preferences. #33133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasmussen merged 4 commits into from
Jul 7, 2021
Merged

Try: Polish labels and consolidate options in preferences. #33133

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d0452a
Try: Polish labels and consolidate options in preferences.
jasmussen Jul 1, 2021
2a94d31
Fix typo.
jasmussen Jul 5, 2021
ba08014
Rephrase text labels option.
jasmussen Jul 6, 2021
56f2434
Update snapshots.
jasmussen Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rephrase text labels option.
  • Loading branch information
@jasmussen
jasmussen committed Jul 6, 2021
commit ba080147b4fda567da2e689fca47a946f43c5f13
4 changes: 1 addition & 3 deletions packages/edit-post/src/components/preferences-modal/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,7 @@ export default function PreferencesModal() {
/>
<EnableFeature
featureName="showIconLabels"
help={ __(
'Shows text instead of icons in the toolbar.'
) }
help={ __( 'Shows text instead of icons.' ) }
label={ __( 'Display button labels' ) }
/>
<EnableFeature
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-post/src/components/preferences-modal/test/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ exports[`PreferencesModal should match snapshot when the modal is active small v
>
<WithSelect(WithDispatch(BaseOption))
featureName="showIconLabels"
help="Shows text instead of icons in the toolbar."
help="Shows text instead of icons."
label="Display button labels"
/>
<WithSelect(WithDispatch(BaseOption))
Expand Down