Fix block parser to ignore whitespace between block grammar #33136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] Parsing
|
Size Change: +821 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Unit tests are all passing locally...which is odd. |
Contributor
Author
|
@ellatrix Non urgent, but I wonder if at some point you could cast your eyes on this one and advise if you think it's sensible that the parser should not create a freeform content block when it encounters content that is purely whitespace between block definitions during parse? |
7 tasks
Contributor
|
One counter-example that comes to mind is: Where I would maybe expect to have an empty paragraph or two between these blocks. I'm not sure how that would end up in my clipboard though. |
draganescu
added
[Type] Enhancement
Member
|
Closing this as it looks like #33164 fixed the issue. |
Contributor
Author
|
I'm actually going to reopen this to see if it's sensible that we should be creating random freeform blocks for completely empty whitespace. I've removed from Widgets board - which I should have done previously. Apologies @noisysocks. |
Member
Contributor
|
Thanks for the ping, @gziolo. I would recommend against this change. My reasons are:
document.body.innerHTML = `<div>
<p>p</p>
<div>
<p>sub</p>
</div>
</div>` |
Contributor
Author
|
Great. That's all I needed to know. Closing as not an Issue. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33097.
If you paste the following into the Widgets Editor
...you will get some
wp:nullblocks inserted into your post. These will be marked asundefinedblocks.It looks as though the default block parser is treating newline characters as something to be made into a
core/freeformblock. However, in Widgets Editorcore/freeformhas been disabled in order to remove the usage of the Classic block and so we end up with acore/missingblock as a fallback.Nonetheless, it is completely valid that HTML in between block grammar should be converted into a freeform block, but we should not do this for empty whitespace.
This PR fixes this by checking whether the parsed "HTML" between blocks contains more than just whitespace. ONly then will it create a freeform block to represent it.
As a result, if you paste in the test data above it will not result in
wp:nullblocks being created.How has this been tested?
core/paragraphblock.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).