Skip to content

PostPublishButton: Disable if saving non-post entities #33140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ockham merged 8 commits into from
Jul 8, 2021
Merged

PostPublishButton: Disable if saving non-post entities #33140

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a085c04
core-data: Add __experimentalGetEntitiesBeingSaved() selector
ockham Jul 1, 2021
c979ca3
Editor: Add isSavingNonPostEntityChanges() selector
ockham Jul 1, 2021
8245031
PostPublishButton: Use isSavingNonPostEntityChanges() to determine bu…
ockham Jul 1, 2021
50e896f
Disable the Cancel button, too
ockham Jul 1, 2021
dc72ccb
Add unit test for __experimentalGetEntitiesBeingSaved
ockham Jul 5, 2021
ff1ca28
Add unit test coverage for isSavingNonPostEntityChanges
ockham Jul 5, 2021
73c59c2
Typo
ockham Jul 5, 2021
61d0634
Absorb non-post entity related criteria into is{Button|Toggle}Disabled
ockham Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable the Cancel button, too
  • Loading branch information
@ockham
ockham committed Jul 5, 2021
commit 50e896f2a19c2e321ba57c744b2f38cb8c6fab17
9 changes: 8 additions & 1 deletion packages/editor/src/components/post-publish-panel/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export class PostPublishPanel extends Component {
isPublishSidebarEnabled,
isScheduled,
isSaving,
isSavingNonPostEntityChanges,
onClose,
onTogglePublishSidebar,
PostPublishExtension,
Expand Down Expand Up @@ -97,7 +98,11 @@ export class PostPublishPanel extends Component {
/>
</div>
<div className="editor-post-publish-panel__header-cancel-button">
<Button onClick={ onClose } variant="secondary">
<Button
disabled={ isSavingNonPostEntityChanges }
onClick={ onClose }
variant="secondary"
>
{ __( 'Cancel' ) }
</Button>
</div>
Expand Down Expand Up @@ -140,6 +145,7 @@ export default compose( [
isEditedPostBeingScheduled,
isEditedPostDirty,
isSavingPost,
isSavingNonPostEntityChanges,
} = select( editorStore );
const { isPublishSidebarEnabled } = select( editorStore );
const postType = getPostType( getEditedPostAttribute( 'type' ) );
Expand All @@ -156,6 +162,7 @@ export default compose( [
isPublished: isCurrentPostPublished(),
isPublishSidebarEnabled: isPublishSidebarEnabled(),
isSaving: isSavingPost(),
isSavingNonPostEntityChanges: isSavingNonPostEntityChanges(),
isScheduled: isCurrentPostScheduled(),
};
} ),
Expand Down