Add width: 100% to components-base-control inside wp-block-legacy-widget #33141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Block] Legacy Widget
|
Size Change: +21 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
adamziel
force-pushed
the
fix/placeholder-text-truncated
branch
from
d95d19d to
4e6bfeb
Compare
Contributor
Author
|
The failing tests are the same as on trunk |
getdave
approved these changes
Jul 2, 2021
Contributor
getdave
left a comment
getdave
left a comment
There was a problem hiding this comment.
⭐ Nice work. This fix does the job and is nicely limited in scope.
Screen.Capture.on.2021-07-02.at.16-06-01.mp4
adamziel
force-pushed
the
fix/placeholder-text-truncated
branch
from
4e6bfeb to
dd30f23
Compare
noisysocks
added
the
Backport to WP 6.9 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 5, 2021
youknowriad
removed
the
Backport to WP 6.9 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 6, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #33124
The truncation problem is caused by the
max-width: calc( 100% 10px );CSS rule on.components-flex-itemcombined with the fact thatcomponents-base-controldoesn't have any width set:At the moment there is no way of adding a class name to that components-base-control div, so I added a special rule to legacy widget's stylesheet. I used
width: 100%so the consequence is that the select box is now full-width. I think that's okay, and we could always make it smaller by adding width: auto to.components-input-control__containerTest plan: