Tools: Husky upgrade and git ignorance improved

[shivapoudel]

Description

• With husky 7.0.0, .husky/.gitignore is now unnecessary and can be removed. Ref: Build: Upgrade husky package to the latest version #32077 (comment)
• Add declaration to PHP files that will always have LF line endings on checkout.
• Windows-specific file Thumbs.db ignorance.
• Remove composer created vendor dir by including in .gitignore.

Types of changes

Just a development files changes.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @shivapoudel! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[gziolo]

I have only one concern regarding the changes in .gitattributes. Otherwise it looks like Husky v7 fixed the issue with _ subfolder 👍🏻

Thank you for the follow-up on the Husky integration 😄

[gziolo]

Nice one, thank you for your contribution 💯

[gziolo]

It looks like vendor/.gitignore ensures that the vendor folder exists while running the script that builds the zip file for the Gutenberg plugin:

There might be more places related to vendor scripts that assume that the vendor folder exists.

It's very unfortunate, but I think it's simpler to leave it as is for now to unblock this PR.

[gziolo]

See above.

[shivapoudel]

@nylen As I am aware of vendor directory is utilized by Composer dependencies but it is used to download vendor JS files through this PR #1025

@gziolo If this vendor JS files can be in tmp, dist or somewhere else that would be nice in my opinion!

[gziolo]

All green, let's land it 🎉

[github-actions]

Congratulations on your first merged pull request, @shivapoudel! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

[gziolo]

If this vendor JS files can be in tmp, dist or somewhere else that would be nice in my opinion!

Good observation, maybe build/vendor/ would be a better location, but it requires some changes in how those scripts are downloaded and consumed.