components: Add normalizeArrowKey #33208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
sarayourfriend
added
[Feature] Component System
Contributor
Maybe creating a simple input element, adding this in the |
Contributor
Nevermind, I just realised that this is an issue with IE / Edge. Yeah I guess that the only way would be a few small unit tests:
|
sarayourfriend
force-pushed
the
add/normalize-arrow-key
branch
from
2a38517 to
7fd294c
Compare
Contributor
Author
|
Added tests, ready for review! |
ciampo
approved these changes
Jul 7, 2021
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
LGTM! Thank you for adding the tests 🚀
sarayourfriend
added a commit
that referenced
this pull request
Jul 15, 2021
* components: Add normalizeArrowKey * Add tests * Improve the test
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
normalizeArrowKeyutility required by TextInputHow has this been tested?
Not sure how to test this effectively without testing the implementation details.
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).