Admin PWA: make readme private #33216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
50cd774 should do the trick. |
|
Size Change: +91 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
Member
|
Hmm, it looks like private packages aren't filtered out from the block editor handbook anymore. I will look into it. |
gziolo
approved these changes
Jul 6, 2021
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
It should be good now with all private packages removed from the handbook. They aren't published to npm so they shouldn't be really exposed there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #33102 (comment)
@gziolo I'm not sure how I should make it private. Do I just remove the entry?
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).