[Mobile] Pass the Gallery v2 Flag over from the editor #33314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocks at the point that the block validation is run
… innerBlocks at the point that the block validation is run" This reverts commit 4d95e95.
… available at point of block validation
… gallery - with the idea that we will improve the innerblocks drag and drop in a later PR
This reverts commit 9b0abcc.
…existing gallery - with the idea that we will improve the innerblocks drag and drop in a later PR" This reverts commit cc05d60.
…transform when dragging multiple images onto the gallery
…mponent some times
… is async so need to keep circling through the innerblocks updates until we have all the data we need
…mages have data resolved
…27087) * Add loading spinner for image size options Co-authored-by: Glen Davies <[email protected]>
Contributor
Author
|
Yeah, I had to pull |
…gallery-to-nested-image-blocks
…refactor/gallery-as-nested-image-blocks-editor-settings_v2
chipsnyder
removed request for
adamsilverstein,
adamziel,
ajitbohra,
atimmer,
cameronvoell,
chrisvanpatten,
dmsnell,
draganescu,
ellatrix,
getdave,
guarani,
gziolo,
kevin940726 and
mmtr
Base automatically changed from
refactor/gallery-to-nested-image-blocks
to
trunk
August 19, 2021 23:39
…locks-editor-settings_v2
…locks-editor-settings_v2
…locks-editor-settings_v2
Pass the Gallery v2 Flag over from the editor on Android
mkevins
approved these changes
Sep 2, 2021
Contributor
mkevins
left a comment
mkevins
left a comment
There was a problem hiding this comment.
Tested via: wordpress-mobile/WordPress-iOS#16832 (review) and everything is working as expected. Thanks! 👍
…locks-editor-settings_v2
antonis
deleted the
rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
gutenberg-mobile:wordpress-mobile/gutenberg-mobile#3713WordPress-iOS:wordpress-mobile/WordPress-iOS#16832WordPressKit-iOS:wordpress-mobile/WordPressKit-iOS#417Description
This passes the value of the editor setting
__unstableGalleryWithImageBlocksfrom the Native Apps to the editor at initialization and after a settings update.__unstableGalleryWithImageBlocksis fetched via the/wp-block-editor/v1/settingsAPI by the mobile apps alongside theme settings. The associated PRs attached here handle the iOS side of the changes.📓 The Android side of this still needs to be handled.
How has this been tested?
Testing this can be a bit involved:
Setup
wp-env startor generate a new bundle.To Test
Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).