Skip to content

Fixes targeted for WordPress 5.8 RC3 #33354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 13 commits into from
Jul 13, 2021
Merged

Fixes targeted for WordPress 5.8 RC3 #33354

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b8f2ad0
Safari: see if compositing layer size is more reasonable when positio…
gwwar Jun 29, 2021
7dac75f
Site Logo Block: update Site Logo block UI and option syncing (#33179)
creativecoder Jul 6, 2021
bc0c153
Fix moving inner blocks in the Widgets Customizer (#33243)
kevin940726 Jul 8, 2021
d6cbaca
Allow themes to provide empty values for `color.duotone` and `spacing…
nosolosw Jul 8, 2021
c0616d7
Update getTermsInfo() to workaround parsing issue for translatable st…
ocean90 Jul 12, 2021
e83dcf0
Specify what settings can be part of `settings.layout` (#33303)
nosolosw Jul 12, 2021
cc758d5
Update conditions to hide duotone panel (#33295)
nosolosw Jul 12, 2021
98de9a2
Skipping more e2e tests (#33353)
youknowriad Jul 12, 2021
0365552
Skip unstable e2e tests (#33352)
youknowriad Jul 12, 2021
bb010c1
Prevent entering invalid values in the Query Loop block config (#33285)
youknowriad Jul 12, 2021
80d8525
Merge conflicting `wp.editor` objects into a single, non-conflicting …
adamziel Jul 9, 2021
0d2fa41
Do not show color panel if no colors within (#33369)
nosolosw Jul 13, 2021
52019e2
Avoid calling `gutenberg_` functions within code shipped through Word…
desrosj Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prevent entering invalid values in the Query Loop block config (#33285)
  • Loading branch information
@youknowriad
youknowriad committed Jul 12, 2021
commit bb010c16bc794d90e69430e88f4255351693c94e
37 changes: 27 additions & 10 deletions packages/block-library/src/query/edit/query-toolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,18 @@ export default function QueryToolbar( {
labelPosition="edge"
min={ 1 }
max={ 100 }
onChange={ ( value ) =>
onChange={ ( value ) => {
if (
isNaN( value ) ||
value < 1 ||
value > 100
) {
return;
}
setQuery( {
perPage: +value ?? -1,
} )
}
perPage: value,
} );
} }
step="1"
value={ query.perPage }
isDragEnabled={ false }
Expand All @@ -78,9 +85,16 @@ export default function QueryToolbar( {
labelPosition="edge"
min={ 0 }
max={ 100 }
onChange={ ( value ) =>
setQuery( { offset: +value } )
}
onChange={ ( value ) => {
if (
isNaN( value ) ||
value < 0 ||
value > 100
) {
return;
}
setQuery( { offset: value } );
} }
step="1"
value={ query.offset }
isDragEnabled={ false }
Expand All @@ -98,9 +112,12 @@ export default function QueryToolbar( {
label={ __( 'Max page to show' ) }
labelPosition="edge"
min={ 0 }
onChange={ ( value ) =>
setQuery( { pages: +value } )
}
onChange={ ( value ) => {
if ( isNaN( value ) || value < 0 ) {
return;
}
setQuery( { pages: value } );
} }
step="1"
value={ query.pages }
isDragEnabled={ false }
Expand Down