Suggestion List: Check if a node exists to scroll into view #33419
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing node source will cause an error in the scrollIntoView function and crash the editor.
Mamaduka
added
[Package] Components
|
Size Change: +6 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Backport to WP 6.9 Beta/RC
youknowriad
approved these changes
Jul 15, 2021
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for the fix
Member
Author
|
Thanks for the review, @youknowriad. |
youknowriad
pushed a commit
that referenced
this pull request
Jul 15, 2021
Missing node source will cause an error in the scrollIntoView function and crash the editor.
youknowriad
removed
the
Backport to WP 6.9 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 15, 2021
Missing node source will cause an error in the scrollIntoView function and crash the editor.
gwwar
pushed a commit
that referenced
this pull request
Jul 19, 2021
Missing node source will cause an error in the scrollIntoView function and crash the editor.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missing node source will cause an error in the
scrollIntoViewfunction and crash the editor. PR adds a check before scrolling selected suggestions into the view.Fixes #30932.
How has this been tested?
Screenshots
CleanShot.2021-07-14.at.14.57.19.mp4
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).