Mobile Release v1.57.1 #33492
Merged
Mobile Release v1.57.1 #33492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyhun
added
the
Mobile App - i.e. Android or iOS
5 tasks
* Fix: Button button value to be stored as a value + unit * Update the test to include the px values. * Fix toFixed to work more as expected. This resulted in somecase the up or down clicks with proper incoments. * Remove decimalNum propertly from unit control This unit now gets calculated from the step value. * Update Button Component to now accept any unit. * fix toFixed to return a number instead of a string * Update with comments for more clarity for getDecimal * Only calculate decimalNum once. * Make the stepper cell return integers instead of floats for nicer numbers * Normalize floats to always include leading zero * Make the code not repeat itself * Display nicer numbers when the numbers are integers from 1.00 to 1 * Adjust the intergration test so it passes again * minor
Member
Author
|
Temporarily re-targeted to |
AmandaRiu
force-pushed
the
rnmobile/release_1.57.1
branch
from
9dc00fd to
7ee5882
Compare
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
…unctionality (#33211) * Add setup for button radius test * Tweak query in test * Clean up bottons tests * Clean up buttons test further * RNMobile: Fix reusable block test assertion The test should assert the existance of a React element but because of a missing `await`, was instead asserting an unresolved Promise instead. Since the unresolved Promise is a value, `toBeDefined` was returning `true` and the test was passing. Fixing the test involves resolving the Promise using `await` so that what's asserted is an actual React element. * Update useResizeObserver mock Co-authored-by: Carlos Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release 1.57.1 of the react-native-editor and Gutenberg-Mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3730
Checklist:
*.native.jsfiles for terms that need renaming or removal).