Skip to content

Site Editor: Remove styles reset as script dependency #33522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
creativecoder wants to merge 6 commits into from
Closed

Site Editor: Remove styles reset as script dependency #33522

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6dd385d
Site Editor: Remove styles reset
creativecoder Jul 16, 2021
8a6eed5
Remove previous code for diabling style reset in the site editor
creativecoder Jul 19, 2021
77acc8a
Expand comment
creativecoder Jul 26, 2021
6879c32
Reintroduce wp styles as an empty array
jeyip Jul 27, 2021
c687deb
Revert changes to lib/client-assets.php
creativecoder Aug 12, 2021
1d10a56
Use wp_styles function rather than the global
creativecoder Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/full-site-editing/edit-site-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,14 @@ function gutenberg_edit_site_init( $hook ) {
wp_enqueue_style( 'wp-block-library-theme' );
}

// Remove wp-reset-editor-styles, as it's not needed in the iframed site editor.
// When the site editor is merged to Core, wp-edit-blocks can be updated to load
// without the styles reset for the site editor. Until then, we remove it manually.
if ( isset( wp_styles()->registered['wp-edit-blocks'] ) ) {
$wp_edit_blocks_dependencies = array_diff( wp_styles()->registered['wp-edit-blocks']->deps, array( 'wp-reset-editor-styles' ) );
wp_styles()->registered['wp-edit-blocks']->deps = $wp_edit_blocks_dependencies;
}

/**
* Fires after block assets have been enqueued for the editing interface.
*
Expand Down