Rnmobile/add/typography controls #33605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enejb
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +6.59 kB (+1%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
enejb
force-pushed
the
rnmobile/add/typography-controls
branch
from
f7569b1 to
428d640
Compare
enejb
force-pushed
the
rnmobile/add/typography-controls
branch
from
7e74313 to
1b6cca5
Compare
geriux
reviewed
Aug 18, 2021
geriux
reviewed
Aug 18, 2021
geriux
reviewed
Aug 18, 2021
Member
|
Can we also include in this PR the removal of this line? Since we are now adding a |
geriux
reviewed
Aug 18, 2021
geriux
reviewed
Aug 18, 2021
Member
|
Hey @enejb can you please update this PR with the latest |
enejb
force-pushed
the
rnmobile/add/typography-controls
branch
from
5cdb0ef to
ff03af7
Compare
enejb
force-pushed
the
rnmobile/add/typography-controls
branch
from
ff03af7 to
438c3db
Compare
Contributor
Author
|
@geriux I removed the commits that were related to the font size changing and rebased the PR. |
geriux
reviewed
Aug 20, 2021
Member
Contributor
Author
|
I addressed the issue and make it look a little nicer on iOS (removed the extra right border that I found). |
This was referenced Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pr attempts to add the typographical controls needed to manipulate the font size and line height.
How has this been tested?
Prereqisits.
Screenshots
Screen.Recording.2021-07-21.at.11.15.53.AM.mov
Types of changes
New Feature for mobile app: Adds font size and line height controls blocks that have it.
Checklist:
*.native.jsfiles for terms that need renaming or removal).