Skip to content

Gallery block refactor: remove the imageCount attribute #33677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glendaviesnz merged 4 commits into from
Jul 26, 2021
Merged

Gallery block refactor: remove the imageCount attribute #33677

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8586af7
Remove the imageCount attribute and use CSS instead to set default co…
Jul 26, 2021
f1d7616
remove unneeded calc
Jul 26, 2021
427065f
Remove unnecessary nested calcs and fix lint error
aaronrobertshaw Jul 26, 2021
ba7ffcd
* Add optional chaining to innerBlockImages in edit wrapper in case i…
Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unneeded calc
  • Loading branch information
Glen Davies committed Jul 26, 2021
commit f1d761663ff2267c6f69ad29a92e76a64caa9c77
2 changes: 1 addition & 1 deletion packages/block-library/src/gallery/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
&.columns-default {
figure.wp-block-image:not(#individual-image) {
margin-right: var(--gallery-block--gutter-size, #{$grid-unit-20});
width: calc(33.33% - calc(var(--gallery-block--gutter-size, 16px) * calc(2) / 3))
width: calc(33.33% - calc(var(--gallery-block--gutter-size, 16px) * 2 / 3))
}
figure.wp-block-image:not(#individual-image):nth-of-type(3n+3) {
margin-right: 0;
Expand Down