Skip to content

components: InputControl to TypeScript #33696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarayourfriend merged 10 commits into from
Aug 6, 2021
Merged

components: InputControl to TypeScript #33696

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bdbd7ea
components: InputControl to TypeScript
sarayourfriend Jul 23, 2021
788daf7
Add back event to onChange
sarayourfriend Jul 26, 2021
82dc830
Fix on validate and remove todo
sarayourfriend Jul 27, 2021
11956d9
Remove cast and allow undefined values
sarayourfriend Jul 28, 2021
fa1d387
Add explanatory comment for omitting prefix
sarayourfriend Aug 2, 2021
d736b46
Use currentTarget
sarayourfriend Aug 2, 2021
6f98642
components: Convert Select to TypeScript (#33784)
sarayourfriend Aug 2, 2021
c4f7a48
Remove unused import
sarayourfriend Aug 2, 2021
7fa7383
Consistently use currentTarget
sarayourfriend Aug 2, 2021
78fccbe
Require isFocused props
sarayourfriend Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use currentTarget
  • Loading branch information
@sarayourfriend
sarayourfriend committed Aug 2, 2021
commit d736b4610d2b4a1d63b3ed179fe1696a2a84d725
7 changes: 3 additions & 4 deletions packages/components/src/input-control/input-field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ function InputField(
};

const handleOnCommit = ( event: SyntheticEvent< HTMLInputElement > ) => {
const nextValue = ( event.target as HTMLInputElement ).value;
const nextValue = event.currentTarget.value;

try {
onValidate( nextValue, event );
Expand Down Expand Up @@ -210,10 +210,9 @@ function InputField(
handleOnMouseDown = ( event: MouseEvent< HTMLInputElement > ) => {
props.onMouseDown?.( event );
if (
event.target !==
( event.target as HTMLInputElement ).ownerDocument.activeElement
event.target !== event.currentTarget.ownerDocument.activeElement
) {
( event.target as HTMLInputElement ).focus();
event.currentTarget.focus();
}
};
}
Expand Down