Fix: Site editor template previews #33825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
Size Change: +60 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
Contributor
I know we may have a similar issue in regular block inserter previews in Firefox too. I don't really know the real issue here. |
youknowriad
reviewed
Aug 3, 2021
| // Template previews need the editor styles to be available. | ||
| <EditorStyles | ||
| styles={ settings.styles } | ||
| /> |
Contributor
There was a problem hiding this comment.
Is this needed because the editor styles are only rendered inside the iframe while the previews are outside the iframe? I think @ellatrix has an alternative fix for this (using iframe for previews somewhere)
Member
|
Would #28165 help here at all? |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template previews are currently broken because of two reasons the height is 0 so they are not visible and the editor styles are not reflected (so they don't reflect the true look of a template).
This PR fixes the editor styles issue and proposes a temporary solution for the height issue.
We have a bug on packages/block-editor/src/components/block-preview/auto.js. Because of some reason contentHeight is always 0. Even though the iframe used for the computation has a height. It seems like useResizeObserver is not returning the height in this case. cc: @youknowriad as someone that worked on packages/block-editor/src/components/block-preview/auto.js in case you are able to help find the root cause of the issue.
How has this been tested?
I went to site editor opened the templates menu navigated with the mouse over the items and verified the template previews appeared.