-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Update @wordpress/components package's contributing guidelines
#33960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
7e93e07
README: add notes
ciampo 37e1759
README: add link to `CONTRIBUTING.md`
ciampo cefad1f
CONTRIBUTING: Add initial notes
ciampo 02114ce
More notes into CONTRIBUTING
ciampo 3d665fb
Update CONTRIBUTING
ciampo 0fb4753
Add `enable` to boolean prefixes
ciampo 00e2b35
Remove `View` suffix for styled components
ciampo 17ccabe
Update folder structure: move styles and types into each subfolder
ciampo 1459214
Less strict working about typescript, rename PolymorphicComponent to …
ciampo c6f6a24
Update packages/components/CONTRIBUTING.md
ciampo f533857
Refer to the repo testing overview docs in the unit test section
ciampo 4c1c200
Update polyfill info
ciampo 89a89d1
Remove "Components Structure" paragraph
ciampo 5238a88
Reword text in "Folder structure" section, exclude shared utilities
ciampo 7acc925
Folder structure schemes: name parent folders, remove useless sub-com…
ciampo 6621f1e
Expand Storybook section
ciampo 6f6d8de
Add details to soft deprecation strategy
ciampo 9d0ece7
Misc smaller improvements
ciampo d394f5d
Fix typo
ciampo 3359502
Expand hooks vs components section, move under composition
ciampo cfc843d
Move sub components naming convention under "APIs consistency" section
ciampo abf50ad
Add Polymorphic components sub-section, reorganise "Components compos…
ciampo 0021dfc
Add more details about listing props through knobs in storybook
ciampo 15f7023
Remove hyphen from subcomponents
ciampo 4520f7e
Add content to the `Context System` section
ciampo 95de8fb
comment out unfinied sections
ciampo 5393b9a
Apply suggestions from code review
ciampo 6647446
Comment out reference to the "composition section"
ciampo 670ca6c
Rename "Emotion" section to "Styling"
ciampo e65518d
Updale unit test section to link directly to components snapshot testing
ciampo b6edc2e
Update the storybook section, adding more details on stories and knobs
ciampo e8bb18d
Link to the Coding Guidelines in the "Documentation" section
ciampo 08cd356
remove note about relevance of SCSS-related docs in README
ciampo c34f731
Update context section with example snippets
ciampo 8c494c8
Format internal links to absolute path format
ciampo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Apply suggestions from code review
Co-authored-by: Haz <[email protected]> Co-authored-by: Greg Ziółkowski <[email protected]>
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.