Skip to content

Block Support: Add min-height block support #33970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonjd wants to merge 9 commits into from
Closed

Block Support: Add min-height block support #33970

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
36aceb3
Add height dimensions block support
aaronrobertshaw Jun 2, 2021
1bd0bf3
Remove custom prefix from theme.json support property
aaronrobertshaw Aug 30, 2021
c2fcb7c
Temporarily disable the unused parameter linting
aaronrobertshaw Aug 13, 2021
b178310
Add min height block supports.
ramonjd Aug 11, 2021
4f9eb9e
Rebasing on top of #32499
ramonjd Aug 11, 2021
9577947
clean empty object when resetting
ramonjd Aug 11, 2021
dee7606
Hi Linter!
ramonjd Aug 11, 2021
6341854
Remove custom prefix from theme.json support property
ramonjd Aug 31, 2021
6ea501b
Update forked dependency to fix typescript error (#34422)
Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove custom prefix from theme.json support property
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed Aug 30, 2021
commit 1bd0bf38612deccb4b2467bf03d89f074437fcd9
2 changes: 1 addition & 1 deletion lib/class-wp-theme-json-gutenberg.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class WP_Theme_JSON_Gutenberg {
),
'custom' => null,
'dimensions' => array(
'customHeight' => null,
'height' => null,
),
'layout' => array(
'contentSize' => null,
Expand Down
2 changes: 1 addition & 1 deletion lib/theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
]
},
"dimensions": {
"customHeight": false
"height": false
},
"spacing": {
"customMargin": false,
Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor/src/hooks/height.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export function resetHeight( { attributes = {}, setAttributes } ) {
* @return {boolean} Whether height control is disabled.
*/
export function useIsHeightDisabled( { name: blockName } = {} ) {
const isDisabled = ! useSetting( 'dimensions.customHeight' );
const isDisabled = ! useSetting( 'dimensions.height' );
return ! hasHeightSupport( blockName ) || isDisabled;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/sidebar/dimensions-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function useHasDimensionsPanel( context ) {
}

function useHasHeight( { name, supports } ) {
const settings = useSetting( 'dimensions.customHeight', name );
const settings = useSetting( 'dimensions.height', name );

return settings && supports.includes( 'height' );
}
Expand Down