Skip to content

Cover block: Unify dimensions panels #34008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonjd wants to merge 11 commits into from
Closed

Cover block: Unify dimensions panels #34008

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6c89606
Add height dimensions block support
aaronrobertshaw Jun 2, 2021
51bbf48
Add min height block supports.
ramonjd Aug 11, 2021
264391d
Rebasing on top of #32499
ramonjd Aug 11, 2021
8d964fd
clean empty object when resetting
ramonjd Aug 11, 2021
c9bad6d
Hi Linter!
ramonjd Aug 11, 2021
76bfd4f
Initial commit: using minheight block supports and removing previous …
ramonjd Aug 11, 2021
8f3d459
Revert theme.json
ramonjd Aug 11, 2021
323e769
Ensuring the block props styles are reflected correctly for min heigh…
ramonjd Aug 12, 2021
96d69b3
Adding minHeigh to theme.json
ramonjd Aug 12, 2021
bfdfb8f
Allow the minHeight support UnitControl to pickup changed unit
aaronrobertshaw Aug 12, 2021
e8ceebd
Adding deprecation
ramonjd Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Hi Linter!
  • Loading branch information
@ramonjd
ramonjd committed Aug 11, 2021
commit c9bad6d115762f0de627636a4999ba1fec6813f0
4 changes: 2 additions & 2 deletions lib/class-wp-theme-json-gutenberg.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class WP_Theme_JSON_Gutenberg {
'text' => null,
),
'dimensions' => array(
'height' => null,
'height' => null,
'minHeight' => null,
),
'spacing' => array(
Expand Down Expand Up @@ -98,7 +98,7 @@ class WP_Theme_JSON_Gutenberg {
),
'custom' => null,
'dimensions' => array(
'customHeight' => null,
'customHeight' => null,
'customMinHeight' => null,
),
'layout' => array(
Expand Down