-
Notifications
You must be signed in to change notification settings - Fork 4.7k
ToolsPanel component: refactor to typescript #34028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7e79847
Start refactor of ToolsPanel component to typescript
b1e2fc0
Add typing for dropdown menu
65fa4f6
Start typing the ToolsPanelHeader component
74ddbd8
Add types for ToolsPanelHeader
15c0ae3
Add remaining types
336efba
More conflict resolution
a1fe287
Update PolymorphicComponent* references to WordPressComponentProps*
8d9d8d7
Fix type issues following rebase
ee69bf8
fix remaining menu item type issues
1174878
Improve menu item types
19dec18
Move remaining eligible ToolsPanel files to TS
aaronrobertshaw bb89386
Revert "Improve menu item types"
aaronrobertshaw 8369760
Revert "Add typing for dropdown menu"
aaronrobertshaw d853e9a
Remove menu group and item type doc block annotations
aaronrobertshaw 19bdce7
Add ts-nocheck to ToolsPanelHeader
aaronrobertshaw bce9e12
Move ts-nocheck to dependencies and fix type errors
aaronrobertshaw 87127db
Improve typing of ToolsPanel
aaronrobertshaw 6c4180e
Add missing dependencies to tools panel item hook
aaronrobertshaw 19cd494
Use optional chaining for onSelect and onDeselect calls
aaronrobertshaw f061db7
Add TypeScript types for function props in READMEs
aaronrobertshaw d4674f1
Enforce boolean for hasMenuItems in ToolsPanelContext
aaronrobertshaw 1f833ab
Make all properties except panelId mandatory in ToolsPanelContext
aaronrobertshaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "Improve menu item types"
This reverts commit 2676061.
- Loading branch information
commit bb89386b05cd47046f1eb85fc3cd779ba76d67c4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.