Unit Control: add some tests for getValidParsedUnit util method #34029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
force-pushed
the
try/unit-control-update-with-incoming-unit
branch
from
3368c90 to
090bfcb
Compare
|
Size Change: 0 B Total Size: 1.03 MB ℹ️ View Unchanged
|
10 tasks
Member
Author
|
Looks like I should have just tried to pass the updated value to the |
ramonjd
changed the title
ramonjd
force-pushed
the
try/unit-control-update-with-incoming-unit
branch
from
0169e2b to
e790ff1
Compare
ramonjd
added
[Package] Components
glendaviesnz
approved these changes
Aug 16, 2021
Contributor
glendaviesnz
left a comment
glendaviesnz
left a comment
There was a problem hiding this comment.
Tested well for me:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR started out as an exploratory mission to coerce the UnitControl component to update the unit value based on incoming changes in the value.
So for example, if the unit is set to
px, but the incoming value is22em, the component would parse and validate the new unit (em) and callsetUnitto update the internal state.Hoorah!
Well, it turns out this was all a bit superfluous seeing that we can pass the updated unit value using the components
unitprop. 🤦Still, along the way we added a few tests for
getValidParsedUnit()so it seemed a shame to abandon them to the cloud, where they would linger, alone and forgotten, like a wet sock in a suburban laundromat.How has this been tested?
Run the tests:
Types of changes
Adding unit tests.
Checklist: