Skip to content

Cover: Move cover min-height into dimensions panel via SlotFill #34065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 3 commits into from
Sep 10, 2021
Merged

Cover: Move cover min-height into dimensions panel via SlotFill #34065

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a75e63c
Move min height into the dimensions block support panel
aaronrobertshaw Aug 13, 2021
df36895
Clear the min height unit attribute
aaronrobertshaw Aug 20, 2021
2ba3fe5
Add panelId to injected ToolsPanelItem
aaronrobertshaw Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add panelId to injected ToolsPanelItem
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed Sep 10, 2021
commit 2ba3fe509d9fe7f5b1fd55f20e103b8902539268
1 change: 1 addition & 0 deletions packages/block-library/src/cover/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,7 @@ function CoverEdit( {
minHeightUnit: undefined,
} ) }
isShownByDefault={ true }
panelId={ clientId }
>
<CoverHeightInput
value={ temporaryMinHeight || minHeight }
Expand Down