Skip to content

Text for dropdown fields within legacy widgets in the Customizer is off centered #34076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevin940726 merged 3 commits into from
Aug 19, 2021
Merged

Text for dropdown fields within legacy widgets in the Customizer is off centered #34076

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d5a9b1
We need to specify the padding-top property because Firefox doesn't r…
anton-vlasenko Aug 13, 2021
64f3809
Don't use Mozilla specific css hacks and just apply proper top and bo…
anton-vlasenko Aug 13, 2021
5f52f34
Let's use 8px (equal to the size of the grid unit) vs 10px (as sugges…
anton-vlasenko Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
We need to specify the padding-top property because Firefox doesn't r… 
…ender text correctly inside the select element in the legacy menu widget.
  • Loading branch information
@anton-vlasenko
anton-vlasenko committed Aug 13, 2021
commit 7d5a9b1c9d28f849dda0b5ac2852e6da3df3353c
5 changes: 5 additions & 0 deletions packages/widgets/src/blocks/legacy-widget/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@
select {
padding-left: $grid-unit-05;
}
@-moz-document url-prefix() {
select {
padding-top: $grid-unit-20;
}
}
}

// Reset z-index set on https://github.com/WordPress/wordpress-develop/commit/f26d4d37351a55fd1fc5dad0f5fef8f0f964908c.
Expand Down