ToolsPanel: Add tools panel item deregistration #34085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
aaronrobertshaw
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +23 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
7 tasks
andrewserong
approved these changes
Aug 16, 2021
Contributor
There was a problem hiding this comment.
LGTM! Smoke tested that it doesn't affect any existing behaviour with the ToolsPanel in use for group, button and columns blocks, and no errors in the console.
I was wondering for a moment if label is always unique enough, but I think it's fair to expect that each item will have a unique label, and we're already treating it as a unique identifier in the toggleItem logic, so this looks good to me 👍
Update: confirmed that it's already documented that tools panel item labels are required and need to be unique 👍
Contributor
Author
|
Thanks for the review @andrewserong 🙇 The dual-purpose nature of the label, being both a human-readable string and the key by which menu items are found, is documented in the component readme. Should there be a desire to change that, we'll address it in a separate PR and this can change with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #34063
Description
ToolsPanelItems to deregister themselves from theToolsPaneland its menu state.This overcomes a problem encountered when injecting controls into a ToolsPanel via a
SlotFill. In that scenario, switching your block selection from one block to another with the sameToolsPanele.g. dimensions, would retain theSlotFillprovided item in the menu.How has this been tested?
Manually and via #34063.
Types of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).