Skip to content

Cover block: update Dimensions panel label to avoid duplicate #34102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonjd wants to merge 2 commits into from
Closed

Cover block: update Dimensions panel label to avoid duplicate #34102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30903af
The dimensions panel has been merged. This panel includes controls su…
ramonjd Aug 17, 2021
57b9b21
Revert label deletion on mobile for now.
ramonjd Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/block-library/src/cover/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ function CoverHeightInput( {
const min = isPx ? COVER_MIN_HEIGHT : 0;

return (
<BaseControl label={ __( 'Minimum height of cover' ) } id={ inputId }>
<BaseControl id={ inputId }>
<UnitControl
id={ inputId }
isResetValueOnUnitChange
Expand Down Expand Up @@ -536,7 +536,7 @@ function CoverEdit( {
</PanelRow>
</PanelBody>
) }
<PanelBody title={ __( 'Dimensions' ) }>
<PanelBody title={ __( 'Minimum height' ) }>
<CoverHeightInput
value={ temporaryMinHeight || minHeight }
unit={ minHeightUnit }
Expand Down