-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Prototype: merge block CSS with theme.json styles
#34180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5d24f76
2ecf48c
a239e86
5f00b48
6f5b3dc
9de58cb
1607e13
6fbf6fb
6764a20
e40b8cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -89,7 +89,30 @@ | |
| "radius": true | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know this probably isn't what anyone wants to hear, but should we consider splitting out the implementation details from the concrete usage on the Button block? That way we can incrementally introduce the capability to new blocks one by one and check and merge PRs as we go. |
||
| } | ||
| }, | ||
| "__experimentalSelector": ".wp-block-button__link" | ||
| "__experimentalSelector": ".wp-block-button__link", | ||
| "__experimentalStyle": { | ||
| "border": { | ||
| "//": "100% causes an oval, but any explicit but really high value retains the pill shape.", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should document this approach.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a "cool" feature that should work across all the JSON files used in WordPress, not only for CSS in JSON.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Related to #35099
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @scruffian You should consider splitting this commenting feature out and making it work on all of
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The feedback in #35099 seems to be that this isn't the best way to do it. |
||
| "radius": "9999px" | ||
| }, | ||
| "color": { | ||
| "text": "#fff", | ||
| "background": "#32373c" | ||
| }, | ||
| "typography": { | ||
| "fontSize": "1.125em", | ||
| "textDecoration": "none" | ||
| }, | ||
| "spacing": { | ||
| "padding": { | ||
| "//": "The extra 2px are added to size solids the same as the outline versions.", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this comment syntax is now a "thing" should we:
|
||
| "top": "calc(0.667em + 2px)", | ||
| "right": "calc(1.333em + 2px)", | ||
| "bottom": "calc(0.667em + 2px)", | ||
| "left": "calc(1.333em + 2px)" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "styles": [ | ||
| { "name": "fill", "label": "Fill", "isDefault": true }, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.