Skip to content

Refactor preferences modal to the interface package #34195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
talldan wants to merge 15 commits into from
Closed

Refactor preferences modal to the interface package #34195

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
cd01533
Refactor components to the interface package
talldan Aug 20, 2021
2e27478
Replace modal and section components
talldan Aug 20, 2021
67f70cb
Replace tabs
talldan Aug 20, 2021
d6c81fd
Fix style of back button
talldan Aug 20, 2021
b7167d9
Fix active tab when selecting a tab on mobile viewport then switching…
talldan Aug 20, 2021
a376f84
Refactor tabs into different components
talldan Aug 20, 2021
05be1fe
Use the interface toggle as the base component for all toggles
talldan Aug 20, 2021
b915d15
Move meta boxes section into panel preferences
talldan Aug 20, 2021
f086938
Fix typos
talldan Aug 23, 2021
b710bd9
Add README for preferences modal
talldan Aug 23, 2021
0bd5c8d
Add toggle docs
talldan Aug 23, 2021
32bcbdf
Update changelogs
talldan Aug 23, 2021
5d0a683
Update metaboxes test and remove preferences panel test
talldan Aug 23, 2021
ae2bd17
Fix e2e test
talldan Aug 23, 2021
d2c6da4
Update unit test
talldan Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update unit test
  • Loading branch information
@talldan
talldan committed Aug 24, 2021
commit d2c6da4845003fe5bd72e0f80f141b08609b5eaf
8 changes: 4 additions & 4 deletions .../src/components/preferences-modal/options/test/__snapshots__/enable-custom-fields.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ exports[`EnableCustomFieldsOption renders a checked checkbox and a confirmation
}

<div
className="edit-post-preferences-modal__option"
className="interface-preferences-modal-toggle"
>
<div
className="components-base-control components-toggle-control emotion-0 emotion-1"
Expand Down Expand Up @@ -78,7 +78,7 @@ exports[`EnableCustomFieldsOption renders a checked checkbox when custom fields
}

<div
className="edit-post-preferences-modal__option"
className="interface-preferences-modal-toggle"
>
<div
className="components-base-control components-toggle-control emotion-0 emotion-1"
Expand Down Expand Up @@ -127,7 +127,7 @@ exports[`EnableCustomFieldsOption renders an unchecked checkbox and a confirmati
}

<div
className="edit-post-preferences-modal__option"
className="interface-preferences-modal-toggle"
>
<div
className="components-base-control components-toggle-control emotion-0 emotion-1"
Expand Down Expand Up @@ -190,7 +190,7 @@ exports[`EnableCustomFieldsOption renders an unchecked checkbox when custom fiel
}

<div
className="edit-post-preferences-modal__option"
className="interface-preferences-modal-toggle"
>
<div
className="components-base-control components-toggle-control emotion-0 emotion-1"
Expand Down
10 changes: 7 additions & 3 deletions packages/edit-post/src/components/preferences-modal/options/test/enable-custom-fields.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { default as TestRenderer, act } from 'react-test-renderer';
* WordPress dependencies
*/
import { Button } from '@wordpress/components';
import { PreferencesModalToggle } from '@wordpress/interface';

/**
* Internal dependencies
Expand All @@ -15,7 +16,6 @@ import {
EnableCustomFieldsOption,
CustomFieldsConfirmation,
} from '../enable-custom-fields';
import BaseOption from '../base';

describe( 'EnableCustomFieldsOption', () => {
it( 'renders a checked checkbox when custom fields are enabled', () => {
Expand All @@ -37,7 +37,9 @@ describe( 'EnableCustomFieldsOption', () => {
<EnableCustomFieldsOption areCustomFieldsEnabled />
);
act( () => {
renderer.root.findByType( BaseOption ).props.onChange( false );
renderer.root
.findByType( PreferencesModalToggle )
.props.onChange( false );
} );
expect( renderer ).toMatchSnapshot();
} );
Expand All @@ -47,7 +49,9 @@ describe( 'EnableCustomFieldsOption', () => {
<EnableCustomFieldsOption areCustomFieldsEnabled={ false } />
);
act( () => {
renderer.root.findByType( BaseOption ).props.onChange( true );
renderer.root
.findByType( PreferencesModalToggle )
.props.onChange( true );
} );
expect( renderer ).toMatchSnapshot();
} );
Expand Down